Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings and remove unneeded code #145

Closed
wants to merge 2 commits into from

Conversation

thealmarty
Copy link
Collaborator

No description provided.

@morganthomas
Copy link
Collaborator

These changes appear to replace is_useful with is_data || is_text. I think this would not change the meaning, except that is_bss was removed. is_bss may not occur in the cases you looked at but it is a case that we need to be able to handle. A .bss section is a data section where the contents are initialized to zero.

@thealmarty
Copy link
Collaborator Author

I didn't think I removed is_bss. I only removed is_useful because I noticed that there's no else case for that. Maybe it does make sense to leave it in though. The semantics is the same I think I just thought less code is better. Please feel free to ignore.

@thealmarty thealmarty closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants